[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

Neal via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 8 17:09:53 PST 2021


nealsid added a comment.

Thanks - all the comments sound good.  I'll upload a new patch.

It seems like the pre-merge check failures are because I incorrectly set the project repo when I first created the revision.  I noticed in the build commands here: https://buildkite.com/llvm-project/premerge-checks/builds/28649#b755747b-7673-4dbc-9189-2d6bbcd1fbd3 that the cmake command doesn't include 'lldb' as a project.  I was able to repro the error on my Debian machine using those commands, and adding lldb to the cmake command seemed to make them go away (tbh, I'm not familiar enough with the normal output of clang-tidy to be sure)

Is there any way to fix that without creating a new revision or would that be easiest? Thanks, sorry about that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98153/new/

https://reviews.llvm.org/D98153



More information about the lldb-commits mailing list