[Lldb-commits] [lldb] fe73331 - [nfc] [lldb] Removed unused operator== for DWARFAbbreviationDeclaration and DWARFAttribute

[Jan Kratochvil via lldb-commits]

Author: Jan Kratochvil
Date: 2021-03-08T19:18:48+01:00
New Revision: fe7333174f54149c00cd32383bf5f6f05455de93

URL: https://github.com/llvm/llvm-project/commit/fe7333174f54149c00cd32383bf5f6f05455de93
DIFF: https://github.com/llvm/llvm-project/commit/fe7333174f54149c00cd32383bf5f6f05455de93.diff

LOG: [nfc] [lldb] Removed unused operator== for DWARFAbbreviationDeclaration and DWARFAttribute

Also DWARFAttribute::operator== was buggy as it was ignoring its `m_value`.

Added: 
    

Modified: 
    lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
    lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h
    lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h

Removed: 
    


################################################################################
diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp b/lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
index 0e9370be15fb..d53d882075f2 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp
@@ -82,9 +82,3 @@ DWARFAbbreviationDeclaration::FindAttributeIndex(dw_attr_t attr) const {
   }
   return DW_INVALID_INDEX;
 }
-
-bool DWARFAbbreviationDeclaration::
-operator==(const DWARFAbbreviationDeclaration &rhs) const {
-  return Tag() == rhs.Tag() && HasChildren() == rhs.HasChildren() &&
-         m_attributes == rhs.m_attributes;
-}

diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h b/lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h
index f70aa71a5958..b9e0204363c1 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.h
@@ -53,7 +53,6 @@ class DWARFAbbreviationDeclaration {
   extract(const lldb_private::DWARFDataExtractor &data,
           lldb::offset_t *offset_ptr);
   bool IsValid();
-  bool operator==(const DWARFAbbreviationDeclaration &rhs) const;
 
 protected:
   dw_uleb128_t m_code;

diff  --git a/lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h b/lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h
index 7bfd2d657ed6..4c78b766a124 100644
--- a/lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h
+++ b/lldb/source/Plugins/SymbolFile/DWARF/DWARFAttribute.h
@@ -30,9 +30,6 @@ class DWARFAttribute {
     form = m_form;
     val = m_value;
   }
-  bool operator==(const DWARFAttribute &rhs) const {
-    return m_attr == rhs.m_attr && m_form == rhs.m_form;
-  }
   typedef std::vector<DWARFAttribute> collection;
   typedef collection::iterator iterator;
   typedef collection::const_iterator const_iterator;