[Lldb-commits] [PATCH] D96952: CRTP-based version of D96817

[Tatyana Krasnukha via Phabricator via lldb-commits]

tatyana-krasnukha added inline comments.


================
Comment at: lldb/source/Interpreter/OptionValueFileSpecList.cpp:169
   std::lock_guard<std::recursive_mutex> lock(m_mutex);
-  return OptionValueSP(new OptionValueFileSpecList(m_current_value));
+  return std::make_shared<OptionValueFileSpecList>(*this);
 }
----------------
JDevlieghere wrote:
> I would call the `Clone` from `Cloneable` here, it's a bit messy with the templates but it makes it makes it clear we're not hand-rolling an implementation but instead are just protecting it wiht a mutex. 
Thanks! Did this before landing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96952/new/

https://reviews.llvm.org/D96952