[Lldb-commits] [PATCH] D50299: Migrate to llvm::unique_function instead of static member functions for callbacks

Neal via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 26 22:10:52 PST 2021


nealsid added a comment.

In D50299#2589289 <https://reviews.llvm.org/D50299#2589289>, @JDevlieghere wrote:

> Thanks Neal. Can you run clang-format again and upload the diff with context (`git diff -U9999`). Overall this looks pretty good.

Thanks for the review.  I have run clang-format and am currently running through a bunch of testing with the completion/suggestion features just to make sure.  Hope to get it updated in the next couple of days.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50299/new/

https://reviews.llvm.org/D50299



More information about the lldb-commits mailing list