[Lldb-commits] [PATCH] D85770: Build a flat LLDB.framework for embedded Darwin targets

[Shoaib Meenai via Phabricator via lldb-commits]

smeenai added inline comments.


================
Comment at: lldb/cmake/modules/LLDBFramework.cmake:142-147
+  add_custom_command(TARGET liblldb POST_BUILD
+    COMMAND ${CMAKE_COMMAND} -E create_symlink
+            Versions/Current/XPCServices
+            ${LLDB_FRAMEWORK_ABSOLUTE_BUILD_DIR}/LLDB.framework/XPCServices
+    COMMENT "LLDB.framework: create symlink XPCServices"
+  )
----------------
This bit appears to have been introduced by this revision, without any equivalent existing before. This is causing issues for us when we build an LLDB framework in LLVM 12, because `Versions/Current/XPCServices` doesn't exist, so the created symlink is dangling. Is there some other target which should be creating that directory? (This is the only instance of `XPCServices` I see in LLDB's build.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D85770/new/

https://reviews.llvm.org/D85770