[Lldb-commits] [PATCH] D97284: [lldb][AArch64] Add MTE CPU feature test predicate
Muhammad Omair Javaid via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Feb 26 03:47:10 PST 2021
omjavaid accepted this revision.
omjavaid added a comment.
This revision is now accepted and ready to land.
This is accepted with a caveat above.
Comment at: lldb/packages/Python/lldbsuite/test/lldbtest.py:1288
+ for line in f.readlines():
+ if line.startswith("Features"):
+ features = line.split(':').split()
On AArch64 targets CPU features in cpuinfo file are written as Features while on x86 they are written as flags.
So Either we change the function name to reflect it can only be used for AArch64 or keep the previous logic to make it architecture independent.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits