[Lldb-commits] [PATCH] D97486: [lldb/Core] Change large function threshold variable into a setting.

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/source/Core/CoreProperties.td:31
     Desc<"The default frame format string to use when displaying stack frame information for threads.">;
+  def StopDisassemblySize: Property<"stop-disassembly-size", "UInt64">,
+    Global,
----------------
Nit, let's move this next to `StopDisassemblyCount` and `StopDisassemblyDisplay`. 


================
Comment at: lldb/source/Core/CoreProperties.td:31
     Desc<"The default frame format string to use when displaying stack frame information for threads.">;
+  def StopDisassemblySize: Property<"stop-disassembly-size", "UInt64">,
+    Global,
----------------
JDevlieghere wrote:
> Nit, let's move this next to `StopDisassemblyCount` and `StopDisassemblyDisplay`. 
Sorry to go on about this but now it doesn't convey that it's the maximum size. Maybe `stop-disassembly-max-size` or `stop-disassembly-size-threshold`. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97486/new/

https://reviews.llvm.org/D97486