[Lldb-commits] [PATCH] D97441: [debugserver] Fix logic to extract app bundle from file path
Jason Molenda via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 24 22:37:40 PST 2021
jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.
Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:3174
+ DNBLogThreadedIf(LOG_PROCESS, "Failed to launch '%s' with FBS",
I wouldn't conditionalize these messages on LOG_PROCESS, I would log unconditionally if the app launch failed (just DNBLog the errors, IMO)
CHANGES SINCE LAST ACTION
More information about the lldb-commits