[Lldb-commits] [PATCH] D97441: [debugserver] Fix logic to extract app bundle from file path

[Jason Molenda via Phabricator via lldb-commits]

jasonmolenda accepted this revision.
jasonmolenda added a comment.
This revision is now accepted and ready to land.

Nice, LGTM.



================
Comment at: lldb/tools/debugserver/source/MacOSX/MachProcess.mm:3174
+    DNBLogThreadedIf(LOG_PROCESS, "Failed to launch '%s' with FBS",
+                     app_bundle_path);
   } break;
----------------
I wouldn't conditionalize these messages on LOG_PROCESS, I would log unconditionally if the app launch failed (just DNBLog the errors, IMO)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97441/new/

https://reviews.llvm.org/D97441