[Lldb-commits] [PATCH] D97249: [lldb] Support debugging utility functions

[Raphael Isemann via Phabricator via lldb-commits]

teemperor accepted this revision.
teemperor added a comment.

Some small nitpicks about comments, otherwise LGTM

I was kinda thinking how we could test this, but all our utility functions are anyway only on macOS and very Obj-C runtime related, so that sounds like a pain to do right...

(PS: Also I would appreciate if you could shoehorn tablegen into this patch somehow. The getters/setters for the properties seems like a good candidate...)



================
Comment at: lldb/source/Expression/FunctionCaller.cpp:103
       m_jit_module_wp = jit_module_sp;
-      process->GetTarget().GetImages().Append(jit_module_sp, 
-                                              true /* notify */);
----------------
unrelated change


================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.cpp:45
+          std::move(name), enable_debugging) {
+  if (enable_debugging) {
+    int temp_fd = -1;
----------------
`// Write the source code to a file so that LLDB's source manager can display it when debugging the code`


================
Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangUtilityFunction.h:52
   ClangUtilityFunction(ExecutionContextScope &exe_scope, std::string text,
-                       std::string name);
+                       std::string name, bool debug = false);
 
----------------
I think this should match the parameter name in the source (and have a doxygen comment).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97249/new/

https://reviews.llvm.org/D97249