[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

[David Spickett via Phabricator via lldb-commits]

DavidSpickett created this revision.
Herald added subscribers: danielkiss, kristof.beyls, krytarowski.
DavidSpickett requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

This feature "memory-tagging+" indicates that lldb-server
supports memory tagging packets. (added in a later patch)

Checking that the system supports MTE requires reading
CPU features which would mean target/OS specific code in
GDBRemoteCommunicationServerCommon.

To avoid this, I've enabled the feature for all AArch64 Linux
at compile time. This is the only platform that has a chance
of supporting tagging. We need to check for tagging per memory
region in any case, so you'll get an error either way if it's
not enabled.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D97282

Files:
  lldb/include/lldb/Target/Process.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
  lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
  lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97282.325765.patch
Type: text/x-patch
Size: 5068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210223/c100cdf3/attachment.bin>