[Lldb-commits] [PATCH] D97165: [lldb] Add deref support and tests to shared_ptr synthetic
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Tue Feb 23 04:06:49 PST 2021
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
This LGTM modulo a missing nullptr check. Thanks for fixing this!
Also we probably should investigate the `strong=` summary differences. I would have blamed the fake constructors we are creating in LLDB, but as this isn't running any expressions this might us just reading the wrong values?
Comment at: lldb/source/Plugins/Language/CPlusPlus/LibCxx.cpp:407
+ auto ptr_sp =
+ valobj_sp->GetChildMemberWithName(ConstString("__ptr_"), true);
+ Status status;
`ptr_sp` should have a nullptr check as `__ptr_` might be missing because we screw up some debug info parsing, or someone renamed the member or idk. In any case, this shouldn't crash.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits