[Lldb-commits] [PATCH] D97235: [lldb] Reinstate support for LLDB_VERSION_STRING

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 22 15:22:19 PST 2021

JDevlieghere created this revision.
JDevlieghere added a reviewer: kastiglione.
JDevlieghere requested review of this revision.

Reinstate support for specifying `-DLLDB_VERSION_STRING` which seems to have gotten accidentally removed in the past.

rdar://38983903 (lldb version number requires an internal patch)



Index: lldb/source/lldb.cpp
--- lldb/source/lldb.cpp
+++ lldb/source/lldb.cpp
@@ -6,14 +6,25 @@
+#include "VCSVersion.inc"
 #include "lldb/lldb-private.h"
+#include "clang/Basic/Version.h"
 using namespace lldb;
 using namespace lldb_private;
-#include "clang/Basic/Version.h"
+// LLDB_VERSION_STRING is set through a define so unlike the other defines
+// expanded with CMake, it lacks the double quotes.
+#define QUOTE(str) #str
+#define EXPAND_AND_QUOTE(str) QUOTE(str)
-#include "VCSVersion.inc"
+static const char *GetLLDBVersion() {
+  return "lldb version " CLANG_VERSION_STRING;
 static const char *GetLLDBRevision() {
@@ -34,11 +45,10 @@
 const char *lldb_private::GetVersion() {
   static std::string g_version_str;
   if (g_version_str.empty()) {
-    g_version_str += "lldb version ";
-    g_version_str += CLANG_VERSION_STRING;
+    const char *lldb_version = GetLLDBVersion();
     const char *lldb_repo = GetLLDBRepository();
     const char *lldb_rev = GetLLDBRevision();
+    g_version_str += lldb_version;
     if (lldb_repo || lldb_rev) {
       g_version_str += " (";
       if (lldb_repo)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D97235.325594.patch
Type: text/x-patch
Size: 1393 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210222/232e2d58/attachment.bin>

More information about the lldb-commits mailing list