[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

Mon Feb 22 12:20:59 PST 2021

labath added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:75-76
     """
-    if "LLDB_DEBUGSERVER_PATH" in os.environ:
-        return os.environ["LLDB_DEBUGSERVER_PATH"]

----------------
goncharov wrote:
> hi @labath ! Sorry for ignorance but what is the reason to remove this resolution through env? For me (due to complicated build system) lldb-server is located in completely different location and "which lldb-server" finds nothing. cc @rupprecht 
The main reason is that the variable was overloaded to mean both the path to the debugserver and lldb-server binaries (which meant that it was not possible to find both), though one could also argue this environment variable override is a gross hack in itself.

Where does `GetLLDBPath(lldb.ePathTypeSupportExecutableDir)` point to in your case? Could it be fixed (maybe via the new `SharedLibraryDirectoryHelper` (D96779)), or lldb-server moved so that the result is correct. If the support executable directory is not correct, then you're likely to run into other problems besides failing tests.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96202/new/

https://reviews.llvm.org/D96202