[Lldb-commits] [PATCH] D96778: [lldb] Fix handling of `DW_AT_decl_file` according to D91014

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 16 18:38:17 PST 2021


jankratochvil added a comment.

In D96778#2567261 <https://reviews.llvm.org/D96778#2567261>, @dblaikie wrote:

> That tests some other cross-cu references, but if it was testing the changes in this patch, wouldn't the test be failing (& I guess it isn't)?

It isn't testing the specific cross-CU case of this patch.

> So seems like more test coverage might be in order? (Either in another test file, or as an addition to the existing one)

Yes, I will try to extend/write one (or @werat can :-) ).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96778/new/

https://reviews.llvm.org/D96778



More information about the lldb-commits mailing list