[Lldb-commits] [PATCH] D96779: [lldb] Fix shared library directory computation on windows

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lldb/include/lldb/Host/HostInfoBase.h:44-46
+  using SharedLibraryDirectoryHelper = void(FileSpec &this_file);
+
+  static void Initialize(SharedLibraryDirectoryHelper *helper = nullptr);
----------------
labath wrote:
> JDevlieghere wrote:
> > Why a function pointer and no `function_ref`?
> function_ref can only be used for objects which do not escape the current function (just like StringRef), while this value is persisted. It could be a std::function, but that seems a bit overkill.
Forgive my ignorance, but how does that apply to `SharedLibraryDirectoryHelper` which is a static method? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96779/new/

https://reviews.llvm.org/D96779