[Lldb-commits] [PATCH] D96680: [lldb-vscode] Emit the breakpoint changed event on location resolved
António Afonso via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Sun Feb 14 18:44:04 PST 2021
aadsm created this revision.
aadsm added reviewers: clayborg, labath, wallace, kusmour.
aadsm requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
VSCode was not being informed whenever a location had been resolved (after being initated as non-resolved), so even though it was actually resolved, the IDE would show a hollow dot (instead of a red dot) because it didn't know about the change.
rG LLVM Github Monorepo
@@ -417,7 +417,8 @@
// of wether the locations were added or removed, the breakpoint
// ins't going away, so we the reason is always "changed".
if ((event_type & lldb::eBreakpointEventTypeLocationsAdded ||
- event_type & lldb::eBreakpointEventTypeLocationsRemoved) &&
+ event_type & lldb::eBreakpointEventTypeLocationsRemoved ||
+ event_type & lldb::eBreakpointEventTypeLocationsResolved) &&
auto bp_event = CreateEventObject("breakpoint");
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 838 bytes
Desc: not available
More information about the lldb-commits