[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

[Med Ismail Bennani via Phabricator via lldb-commits]

mib updated this revision to Diff 323484.
mib marked 3 inline comments as done.
mib edited the summary of this revision.
mib added a comment.
Herald added a subscriber: mgorny.

Address @JDevlieghere comments:

- Instead of having the ScriptedProcess python base class in a SWIG file, I moved it to a python file in the example folder. There is a post-build event that copies it to the python lldb module under to `lldb.plugins` package.
- Added pydoc documentation to the ScriptedProcess base class.
- Removed all the typing hints that prevented the feature to be compatible with Python 2. I, however, kept them in the `MyScriptProcess` example.

I also added a first test that checks that the base class exists in the lldb python module.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95712/new/

https://reviews.llvm.org/D95712

Files:
  lldb/bindings/python/CMakeLists.txt
  lldb/examples/python/scripted_process/my_scripted_process.py
  lldb/examples/python/scripted_process/scripted_process.py
  lldb/test/API/functionalities/scripted_process/Makefile
  lldb/test/API/functionalities/scripted_process/TestScriptedProcess.py
  lldb/test/API/functionalities/scripted_process/main.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D95712.323484.patch
Type: text/x-patch
Size: 11301 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210212/e4bb4f24/attachment.bin>