[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

Jonas Devlieghere via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 12 09:31:38 PST 2021

JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

A few small nits, but overall this LGTM.

Comment at: lldb/include/lldb/API/SBData.h:16
+class ScriptInterpreter;
The linter is right. Did you clang-format your patch? It should add it automatically. 

Comment at: lldb/source/Interpreter/ScriptInterpreter.cpp:31
+    Debugger &debugger, lldb::ScriptLanguage script_lang,
+    lldb::ScriptedProcessInterfaceSP scripted_process_interface_sp)
+    : m_debugger(debugger), m_script_lang(script_lang),
If you gave the scripted_process_interface_sp a default value (`scripted_process_interface_sp = {}`), you could skip the overload, unless that prevents you from forward declaring the interface in the header?

Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:94
+  // right now we know this function exists and is callable..
+  PythonObject py_return(
I know you copied this code but let's turn this and the other comments in this file into full sentences. 

  rG LLVM Github Monorepo



More information about the lldb-commits mailing list