[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Feb 11 14:01:25 PST 2021
teemperor added a comment.
This LGTM module the unrelated changes in that one file. A third pair of eyes probably won't hurt, so I'll give the others a change to look over this before I accept, but otherwise I'll just accept tomorrow.
(Btw, if you intend to cherry-pick this into swift/main for some reason then please let me know as this probably will cause a bunch of conflicts with the temporarily reverted patch from Pavel).
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:38
The changes in this whole file seem like an accidental commit slipped in.
CHANGES SINCE LAST ACTION
More information about the lldb-commits