[Lldb-commits] [lldb] e87b8e4 - [lldb] Log the actual expression result in UserExpression::Evaluate

Raphael Isemann via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 11 07:15:20 PST 2021


Author: Raphael Isemann
Date: 2021-02-11T16:15:01+01:00
New Revision: e87b8e4498df3bc1fcb751dfa24816ecf1ac02bd

URL: https://github.com/llvm/llvm-project/commit/e87b8e4498df3bc1fcb751dfa24816ecf1ac02bd
DIFF: https://github.com/llvm/llvm-project/commit/e87b8e4498df3bc1fcb751dfa24816ecf1ac02bd.diff

LOG: [lldb] Log the actual expression result in UserExpression::Evaluate

This used to be a LLDB_LOGF call that used the printf %s syntax.
0ab109d43d9d8389fe686ee8df4a82634f246b55 changed it to LLDB_LOG but didn't
update this format string to use formatv's syntax so this just printed '%s'.

Added: 
    

Modified: 
    lldb/source/Expression/UserExpression.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Expression/UserExpression.cpp b/lldb/source/Expression/UserExpression.cpp
index 5beed4657b37..c6a288a30b17 100644
--- a/lldb/source/Expression/UserExpression.cpp
+++ b/lldb/source/Expression/UserExpression.cpp
@@ -362,7 +362,7 @@ UserExpression::Evaluate(ExecutionContext &exe_ctx,
 
           LLDB_LOG(log,
                    "== [UserExpression::Evaluate] Execution completed "
-                   "normally with result %s ==",
+                   "normally with result {0} ==",
                    result_valobj_sp->GetValueAsCString());
         } else {
           LLDB_LOG(log, "== [UserExpression::Evaluate] Execution completed "


        


More information about the lldb-commits mailing list