[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

Thu Feb 11 05:24:17 PST 2021

labath added inline comments.

================
Comment at: lldb/packages/Python/lldbsuite/test/tools/lldb-server/lldbgdbserverutils.py:75-79
-    if "LLDB_DEBUGSERVER_PATH" in os.environ:
-        return os.environ["LLDB_DEBUGSERVER_PATH"]

-    return _get_debug_monitor_from_lldb(
-        lldbtest_config.lldbExec, "lldb-server")
----------------
rupprecht wrote:
> labath wrote:
> > rupprecht wrote:
> > > labath wrote:
> > > > @rupprecht : I'm adding you mainly because my last attempt to change this function broke some google integration stuff.
> > > Thanks, patching this in now! (Sorry for the delay, I was out a couple days)
> > Sure, np. Let me know how it works out.
> Everything I've tried to throw this against seems to be working. I'm not sure exactly what the problem was before though. Seems fine to land and I can take a closer look if something fails later. Thanks for the heads up!
Thanks for checking it out.

The previous patch simply removed the LLDB_DEBUGSERVER_PATH thingy, and left the original logic logic in place (which was calculating the lldb server location based on realpath(3) of the lldb binary, which does not work well inside google).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96202/new/

https://reviews.llvm.org/D96202