[Lldb-commits] [PATCH] D95185: lldb: repair the standalone build for Windows
Raphael Isemann via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 10 23:54:19 PST 2021
teemperor requested changes to this revision.
teemperor added a comment.
This revision now requires changes to proceed.
(I'm very sorry for the delay, that slipped out of my review queue.)
Wouldn't changing this logic to an explicit `get_target_property` call break the multi-config projects (where there are multiple possible paths)?
I actually think the easiest solution is to just delete the `file(MAKE_DIRECTORY ...` line. As you described it's not doing what it should and as we create the directory in the custom command below it is redundant. I believe this line is only a remnant from when I tried to get this working in non-multi-config generator setups.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits