[Lldb-commits] [lldb] 309d40f - [lldb] Use internal_dict name over dict in python examples

[Dave Lee via lldb-commits]

Author: Dave Lee
Date: 2021-02-10T15:11:00-08:00
New Revision: 309d40f05228ef71860afe1c179a3c8dcc4d7e79

URL: https://github.com/llvm/llvm-project/commit/309d40f05228ef71860afe1c179a3c8dcc4d7e79
DIFF: https://github.com/llvm/llvm-project/commit/309d40f05228ef71860afe1c179a3c8dcc4d7e79.diff

LOG: [lldb] Use internal_dict name over dict in python examples

Follow up to https://reviews.llvm.org/rG483ec136da7193de781a5284f1c37929cc27c05c

Added: 
    

Modified: 
    lldb/bindings/interface/SBBreakpoint.i
    lldb/bindings/interface/SBBreakpointLocation.i
    lldb/source/Commands/CommandObjectTarget.cpp
    lldb/source/Commands/CommandObjectType.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/bindings/interface/SBBreakpoint.i b/lldb/bindings/interface/SBBreakpoint.i
index 37fcc7fbab48..a7048309edd9 100644
--- a/lldb/bindings/interface/SBBreakpoint.i
+++ b/lldb/bindings/interface/SBBreakpoint.i
@@ -184,7 +184,7 @@ public:
 
     %feature("docstring", "
     Set the name of the script function to be called when the breakpoint is hit.
-    To use this variant, the function should take (frame, bp_loc, extra_args, dict) and
+    To use this variant, the function should take (frame, bp_loc, extra_args, internal_dict) and
     when the breakpoint is hit the extra_args will be passed to the callback function.") SetScriptCallbackFunction;
     SBError
     SetScriptCallbackFunction (const char *callback_function_name,

diff  --git a/lldb/bindings/interface/SBBreakpointLocation.i b/lldb/bindings/interface/SBBreakpointLocation.i
index fc37475ba745..354737b98c6a 100644
--- a/lldb/bindings/interface/SBBreakpointLocation.i
+++ b/lldb/bindings/interface/SBBreakpointLocation.i
@@ -74,13 +74,13 @@ public:
 
     %feature("docstring", "
     Set the callback to the given Python function name.
-    The function takes three arguments (frame, bp_loc, dict).") SetScriptCallbackFunction;
+    The function takes three arguments (frame, bp_loc, internal_dict).") SetScriptCallbackFunction;
     void
     SetScriptCallbackFunction (const char *callback_function_name);
 
     %feature("docstring", "
     Set the name of the script function to be called when the breakpoint is hit.
-    To use this variant, the function should take (frame, bp_loc, extra_args, dict) and
+    To use this variant, the function should take (frame, bp_loc, extra_args, internal_dict) and
     when the breakpoint is hit the extra_args will be passed to the callback function.") SetScriptCallbackFunction;
     SBError
     SetScriptCallbackFunction (const char *callback_function_name,

diff  --git a/lldb/source/Commands/CommandObjectTarget.cpp b/lldb/source/Commands/CommandObjectTarget.cpp
index 1cb21384fd2a..f8d3a797ce5f 100644
--- a/lldb/source/Commands/CommandObjectTarget.cpp
+++ b/lldb/source/Commands/CommandObjectTarget.cpp
@@ -4602,7 +4602,7 @@ Python Based Stop Hooks:
   
   When the stop hook is added, the class is initialized by calling:
   
-    def __init__(self, target, extra_args, dict):
+    def __init__(self, target, extra_args, internal_dict):
     
     target: The target that the stop hook is being added to.
     extra_args: An SBStructuredData Dictionary filled with the -key -value 

diff  --git a/lldb/source/Commands/CommandObjectType.cpp b/lldb/source/Commands/CommandObjectType.cpp
index 004c066b57aa..8002b8719ce2 100644
--- a/lldb/source/Commands/CommandObjectType.cpp
+++ b/lldb/source/Commands/CommandObjectType.cpp
@@ -270,7 +270,7 @@ class CommandObjectTypeSummaryAdd : public CommandObjectParsed,
 static const char *g_synth_addreader_instructions =
     "Enter your Python command(s). Type 'DONE' to end.\n"
     "You must define a Python class with these methods:\n"
-    "    def __init__(self, valobj, dict):\n"
+    "    def __init__(self, valobj, internal_dict):\n"
     "    def num_children(self):\n"
     "    def get_child_at_index(self, index):\n"
     "    def get_child_index(self, name):\n"