[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

Tue Feb 9 00:47:09 PST 2021

werat added inline comments.

================
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:3162
+    case DW_AT_decl_file:
+      decl.SetFile(sc.comp_unit->GetSupportFiles().GetFileSpecAtIndex(
+          form_value.Unsigned()));
----------------
jankratochvil wrote:
> Here should be according to my D91014:
> ```
> decl.SetFile(attributes.CompileUnitAtIndex(i)->GetFile(
> ```
> 
Thanks, didn't know about that

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92643/new/

https://reviews.llvm.org/D92643