[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

I can't think of a really good reason why you would need to override the general "step in avoids nodebug" behavior.  I'm pretty sure I was thinking of a trampoline that got you half way to somewhere interesting, at which point you would want to negotiate again for the trampoline to take you the rest of the way.  In that case you would not want to obey the general setting.  But this is really about what happens when you don't find a good place to go, so that seems unnecessary.

It still seems to me like a trampoline which knew that to implement itself, all it had to do was a couple of stepi's - for instance if a dyld stub knew that the stub had been filled in and would jump straight to the target, it could run without letting the other threads go.  That's actually something the dyld stubs could figure out, they just don't at present. So I'd rather not remove this control.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96276/new/

https://reviews.llvm.org/D96276