[Lldb-commits] [PATCH] D96236: [lldb] DWZ 01/08: Pass main DWARFUnit * along DWARFDIEs

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I stopped looking after the first file, as the introduction of DWARF-ness to the CompileUnit class is a show-stopper. These classes are supposed to be independent of the actual format used to represent the data, and having them know anything about DWARF breaks that.
What's the reason for that? We already have a way to obtain the DWARFCompileUnit given a (generic) CompileUnit from within DWARF code (`SymbolFileDWARF::GetDWARFCompileUnit`). Given that your changes are (should be?) inside DWARF code, it's not clear to me why is that not sufficient (?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96236/new/

https://reviews.llvm.org/D96236