[Lldb-commits] [PATCH] D96254: [ELFObjectWriter] Fix `symbol-binding.test` to conform to unsorted local symbols

[Frederik Gossen via Phabricator via lldb-commits]

frgossen created this revision.
frgossen requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

Commit 980d28d9556a <https://reviews.llvm.org/rG980d28d9556a671081719f82aea3de5db4328688> (ELFObjectWriter: Don't sort local symbols) caused
`symbol-binding.test` to fail (see
http://lab.llvm.org:8011/#/builders/96/builds/4268).


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96254

Files:
  lldb/test/Shell/SymbolFile/symbol-binding.test


Index: lldb/test/Shell/SymbolFile/symbol-binding.test
===================================================================
--- lldb/test/Shell/SymbolFile/symbol-binding.test
+++ lldb/test/Shell/SymbolFile/symbol-binding.test
@@ -11,11 +11,11 @@
 image dump symtab
 # CHECK:     Index   UserID DSX Type            File Address/Value Load Address       Size               Flags      Name
 # CHECK-NEXT:------- ------ --- --------------- ------------------ ------------------ ------------------ ---------- ----------------------------------
-# CHECK-NEXT:[    0]      1     Code            0x0000000000000004                    0x0000000000000001 0x00000000 case1_local
-# CHECK-NEXT:[    1]      2     Code            0x0000000000000005                    0x0000000000000001 0x00000000 case2_local
+# CHECK-NEXT:[    0]      1     Code            0x0000000000000001                    0x0000000000000002 0x00000000 sizeless
+# CHECK-NEXT:[    1]      2     Code            0x0000000000000001                    0x0000000000000002 0x00000000 sizeful
 # CHECK-NEXT:[    2]      3     Code            0x0000000000000003                    0x0000000000000001 0x00000000 sizeend
-# CHECK-NEXT:[    3]      4     Code            0x0000000000000001                    0x0000000000000002 0x00000000 sizeful
-# CHECK-NEXT:[    4]      5     Code            0x0000000000000001                    0x0000000000000002 0x00000000 sizeless
+# CHECK-NEXT:[    3]      4     Code            0x0000000000000004                    0x0000000000000001 0x00000000 case1_local
+# CHECK-NEXT:[    4]      5     Code            0x0000000000000005                    0x0000000000000001 0x00000000 case2_local
 # CHECK-NEXT:[    5]      6   X Code            0x0000000000000004                    0x0000000000000001 0x00000010 case1_global
 # CHECK-NEXT:[    6]      7     Code            0x0000000000000005                    0x0000000000000001 0x00000020 case2_weak
 # CHECK-NEXT:[    7]      8   X Code            0x0000000000000006                    0x0000000000000001 0x00000010 case3_global


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96254.322068.patch
Type: text/x-patch
Size: 2068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210208/1f544d66/attachment-0001.bin>