[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

Sat Feb 6 06:28:45 PST 2021

labath added a comment.

In D95802#2546809 <https://reviews.llvm.org/D95802#2546809>, @mgorny wrote:

> In D95802#2546786 <https://reviews.llvm.org/D95802#2546786>, @labath wrote:
>
>> It doesn't look //too// bad, but what's up with the `friend` thingy? What's that used for? Can we get rid of it?
>
> It's needed to access `SetSoftwareBreakpoint()`, though I'm not really sure why that method is not public. Maybe it'd be better to mark it public instead.

The public interface is `SetBreakpoint(..., hardware=false)`, though I can't say I am particularly fond it...

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D95802/new/

https://reviews.llvm.org/D95802