[Lldb-commits] [PATCH] D96201: [nfc] [lldb] Add Dwo assert

Jan Kratochvil via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat Feb 6 06:13:55 PST 2021


jankratochvil created this revision.
jankratochvil added a reviewer: labath.
jankratochvil added a project: LLDB.
Herald added a subscriber: JDevlieghere.
jankratochvil requested review of this revision.

I had it in my local patchset and I did not want to drop it, OK for check-in?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96201

Files:
  lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp


Index: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
===================================================================
--- lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
+++ lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp
@@ -532,6 +532,9 @@
   if (die_offset == DW_INVALID_OFFSET)
     return DWARFDIE(); // Not found
 
+  // SymbolFileDWARF::GetDIE should have found the dwo file already.
+  lldbassert(!GetDwoSymbolFile());
+
   if (!ContainsDIEOffset(die_offset)) {
     GetSymbolFileDWARF().GetObjectFile()->GetModule()->ReportError(
         "GetDIE for DIE 0x%" PRIx32 " is outside of its CU 0x%" PRIx32,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96201.321931.patch
Type: text/x-patch
Size: 626 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210206/5bd5613b/attachment.bin>


More information about the lldb-commits mailing list