[Lldb-commits] [PATCH] D92643: [lldb] Lookup static const members in FindGlobalVariables

[Andy Yankovsky via Phabricator via lldb-commits]

werat added a comment.

Thanks for reviewing!

In D92643#2546732 <https://reviews.llvm.org/D92643#2546732>, @jankratochvil wrote:

> @werat I see you are aware of D81471 <https://reviews.llvm.org/D81471>. Do you or someone else have anything against it? I find it more integrated using the clang type for it but I admit I do not understand the clang integration much.

I don't have anything against it, on the contrary I'm all for it :) As a matter of fact, we've already integrated that patch in our internal LLDB fork a while ago.

But my patch is not a replacement for that one, it complements it by enhancing the `SBTarget:: FindGlobalVariables` API.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D92643/new/

https://reviews.llvm.org/D92643