[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

[Martin Storsjö via Phabricator via lldb-commits]

mstorsjo added a comment.

The change looks ok to me. In my environments, the main branch does build correctly, but this should be good for consistency in any case. (The 12.x release branch does need a cherrypick though - but it'd be good to settle this first.)

I can test build it in a couple hours, I'll mark it as formally approved after doing that.



================
Comment at: lldb/tools/lldb-vscode/IOStream.cpp:11
 
-#if !LLVM_ON_UNIX
+#if defined(_WIN32) 
 #include <io.h>
----------------
There seems to be trailing whitespace here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96060/new/

https://reviews.llvm.org/D96060