[Lldb-commits] [lldb] 644ef58 - Print the "no plugin" warning only when there is no plugin

[Adrian Prantl via lldb-commits]

Author: Adrian Prantl
Date: 2021-02-04T11:06:10-08:00
New Revision: 644ef580735c9fe4808de89c86a3e476ef1c4fad

URL: https://github.com/llvm/llvm-project/commit/644ef580735c9fe4808de89c86a3e476ef1c4fad
DIFF: https://github.com/llvm/llvm-project/commit/644ef580735c9fe4808de89c86a3e476ef1c4fad.diff

LOG: Print the "no plugin" warning only when there is no plugin

... and not when the typesystem failed to initialize.

rdar://72562341

Differential Revision: https://reviews.llvm.org/D95992

Added: 
    

Modified: 
    lldb/source/Target/Process.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/source/Target/Process.cpp b/lldb/source/Target/Process.cpp
index 518a6934059e..a645f1be5b3c 100644
--- a/lldb/source/Target/Process.cpp
+++ b/lldb/source/Target/Process.cpp
@@ -5684,9 +5684,9 @@ void Process::PrintWarningUnsupportedLanguage(const SymbolContext &sc) {
   LanguageType language = sc.GetLanguage();
   if (language == eLanguageTypeUnknown)
     return;
-  auto type_system_or_err = sc.module_sp->GetTypeSystemForLanguage(language);
-  if (auto err = type_system_or_err.takeError()) {
-    llvm::consumeError(std::move(err));
+  LanguageSet plugins =
+      PluginManager::GetAllTypeSystemSupportedLanguagesForTypes();
+  if (!plugins[language]) {
     PrintWarning(Process::Warnings::eWarningsUnsupportedLanguage,
                  sc.module_sp.get(),
                  "This version of LLDB has no plugin for the %s language. "