[Lldb-commits] [PATCH] D96060: [lldb-vscode] correctly use Windows macros

walter erquinigo via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 4 10:09:56 PST 2021


wallace created this revision.
wallace added reviewers: mstorsjo, stella.stamenova.
wallace requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.

@mstorsjo found a mistake that I made when trying to fix some Windows
compilation errors encountered by @stella.stamenova.

I was incorrectly using the LLVM_ON_UNIX macro. In any case, proper use
of

  #if defined(_WIN32)

should be the actual fix.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D96060

Files:
  lldb/tools/lldb-vscode/FifoFiles.cpp
  lldb/tools/lldb-vscode/IOStream.cpp
  lldb/tools/lldb-vscode/IOStream.h
  lldb/tools/lldb-vscode/RunInTerminal.cpp
  lldb/tools/lldb-vscode/VSCode.cpp
  lldb/tools/lldb-vscode/lldb-vscode.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D96060.321506.patch
Type: text/x-patch
Size: 4563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20210204/7af5e60b/attachment.bin>


More information about the lldb-commits mailing list