[Lldb-commits] [lldb] 608ee55 - [lldb/test] Stop recording fundamental return types (NFC)
Med Ismail Bennani via lldb-commits
lldb-commits at lists.llvm.org
Tue Feb 2 18:02:01 PST 2021
Author: Med Ismail Bennani
Date: 2021-02-03T02:57:26+01:00
New Revision: 608ee55a317f9f7307c90c720c3ab019926cdb49
URL: https://github.com/llvm/llvm-project/commit/608ee55a317f9f7307c90c720c3ab019926cdb49
DIFF: https://github.com/llvm/llvm-project/commit/608ee55a317f9f7307c90c720c3ab019926cdb49.diff
LOG: [lldb/test] Stop recording fundamental return types (NFC)
It seems that recording fundamental return type is bogus.
This can trigger asserts when running a test with reproducers so this
patch updates the `SBTarget::IsLoaded` test to stop recording them.
Differential Revision: https://reviews.llvm.org/D95686
Signed-off-by: Med Ismail Bennani <medismail.bennani at gmail.com>
Added:
Modified:
lldb/source/API/SBTarget.cpp
Removed:
################################################################################
diff --git a/lldb/source/API/SBTarget.cpp b/lldb/source/API/SBTarget.cpp
index 72702b9b6a7b..b376bc4bd756 100644
--- a/lldb/source/API/SBTarget.cpp
+++ b/lldb/source/API/SBTarget.cpp
@@ -2416,13 +2416,13 @@ bool SBTarget::IsLoaded(const SBModule &module) const {
TargetSP target_sp(GetSP());
if (!target_sp)
- return LLDB_RECORD_RESULT(false);
+ return false;
ModuleSP module_sp(module.GetSP());
if (!module_sp)
- return LLDB_RECORD_RESULT(false);
+ return false;
- return LLDB_RECORD_RESULT(module_sp->IsLoadedInTarget(target_sp.get()));
+ return module_sp->IsLoadedInTarget(target_sp.get());
}
lldb::SBLaunchInfo SBTarget::GetLaunchInfo() const {
More information about the lldb-commits
mailing list