[Lldb-commits] [lldb] b74ae43 - Makefile.rules: Make HOST_OS/OS simply expanded variable to avoid excess uname -s invocations

Fangrui Song via lldb-commits lldb-commits at lists.llvm.org
Sun Jan 17 17:19:39 PST 2021


Author: Fangrui Song
Date: 2021-01-17T17:19:29-08:00
New Revision: b74ae43c44b1c954508149409d3cfe6477be4079

URL: https://github.com/llvm/llvm-project/commit/b74ae43c44b1c954508149409d3cfe6477be4079
DIFF: https://github.com/llvm/llvm-project/commit/b74ae43c44b1c954508149409d3cfe6477be4079.diff

LOG: Makefile.rules: Make HOST_OS/OS simply expanded variable to avoid excess uname -s invocations

This decreases the number of runs from 18 to 1.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/make/Makefile.rules

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
index a7efa15e09df..d715f1ca24e4 100644
--- a/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
+++ b/lldb/packages/Python/lldbsuite/test/make/Makefile.rules
@@ -56,12 +56,12 @@ LLDB_BASE_DIR := $(THIS_FILE_DIR)/../../../../../
 # When running tests from Visual Studio, the environment variable isn't
 # inherited all the way down to the process spawned for make.
 #----------------------------------------------------------------------
-HOST_OS = $(shell uname -s)
+HOST_OS := $(shell uname -s)
 ifneq (,$(findstring windows32,$(HOST_OS)))
-	HOST_OS = Windows_NT
+	HOST_OS := Windows_NT
 endif
 ifeq "$(OS)" ""
-	OS = $(HOST_OS)
+	OS := $(HOST_OS)
 endif
 
 #----------------------------------------------------------------------


        


More information about the lldb-commits mailing list