[Lldb-commits] [PATCH] D94672: Implement vAttachOrWait

[Augusto Noronha via Phabricator via lldb-commits]

augusto2112 marked 4 inline comments as done.
augusto2112 added inline comments.


================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:371
+  StreamString name_with_slash_stream;
+  name_with_slash_stream.Format("/{0}", process_name);
+  auto name_with_slash = name_with_slash_stream.GetString();
----------------
clayborg wrote:
> Do we need to get the correct directory delimiter for the current platform here? This will work for everything except windows. Just wanted to bring this up in case we do.
Turns out that was unnecessary since match_infos are compared by file name and not full path.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94672/new/

https://reviews.llvm.org/D94672