[Lldb-commits] [lldb] d36e879 - [lldb] Disable PipeTest.OpenAsReader on windows

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Jan 11 04:38:01 PST 2021


Author: Pavel Labath
Date: 2021-01-11T13:37:49+01:00
New Revision: d36e879c21c9620c9b6a1a8f45afe46379142d2f

URL: https://github.com/llvm/llvm-project/commit/d36e879c21c9620c9b6a1a8f45afe46379142d2f
DIFF: https://github.com/llvm/llvm-project/commit/d36e879c21c9620c9b6a1a8f45afe46379142d2f.diff

LOG: [lldb] Disable PipeTest.OpenAsReader on windows

This test seems to be broken there (which is not totally surprising as
this functionality was never used on windows). Disable the test while I
investigate.

Added: 
    

Modified: 
    lldb/unittests/Host/PipeTest.cpp

Removed: 
    


################################################################################
diff  --git a/lldb/unittests/Host/PipeTest.cpp b/lldb/unittests/Host/PipeTest.cpp
index e8d2c49c4490..35a44ccf0373 100644
--- a/lldb/unittests/Host/PipeTest.cpp
+++ b/lldb/unittests/Host/PipeTest.cpp
@@ -29,6 +29,8 @@ TEST_F(PipeTest, CreateWithUniqueName) {
                     llvm::Succeeded());
 }
 
+// Test broken
+#ifndef _WIN32
 TEST_F(PipeTest, OpenAsReader) {
   Pipe pipe;
   llvm::SmallString<0> name;
@@ -46,3 +48,4 @@ TEST_F(PipeTest, OpenAsReader) {
       pipe.OpenAsReader(name_ref, /*child_process_inherit=*/false).ToError(),
       llvm::Succeeded());
 }
+#endif


        


More information about the lldb-commits mailing list