[Lldb-commits] [PATCH] D94077: Support unscoped enumeration members in the expression evaluator.

[Andy Yankovsky via Phabricator via lldb-commits]

werat added a comment.

Thanks for the explanation, this makes sense. I've checked the mailing list archives and it seems there was already a discussion about the enumerators in the `.debug_names` index back in 2018 -- http://lists.dwarfstd.org/pipermail/dwarf-discuss-dwarfstd.org/2018-April/004443.html. You were the one to bring it up and the consensus was that the enumerators should go into the index too.

But it seems this was never actually implemented, the latest version of the toolchain doesn't add `DW_TAG_enumerator` entries to the `.debug_names` index. Is there a reason for that or it just slipped through the cracks? Should I bring it up again on the mailing list or we can assume the consensus is still the same and this should be just implemented?

Regarding the changes in the manual index. Do you think there's a better way to implement enumerators lookup? To be honest, I don't see another way. Assuming `.debug_names` and `apple_names` are updated to include the enumerators, `manual_index` should be updated as well to match the behaviour.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94077/new/

https://reviews.llvm.org/D94077