[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

Fri Jan 8 22:07:55 PST 2021

jingham added a comment.

In D93895#2488372 <https://reviews.llvm.org/D93895#2488372>, @clayborg wrote:

> In D93895#2488249 <https://reviews.llvm.org/D93895#2488249>, @jingham wrote:
>
>> looks good to me too.  When you get around to the wait times & intervals I'd argue for not doing that as a GDBRemote specific addition, as Greg was suggesting above.  There's nothing gdb-remote specific about how long you want the debug agent to wait around for some process to show up.
>
> As long as we are find passing these arguments to _any_ process subclass I am find doing these as options.

I can't see why we wouldn't be, but I'm also not sure why we would need to change any Process API's.  Wouldn't we just add them interval and timeout to the ProcessAttachInfo?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93895/new/

https://reviews.llvm.org/D93895