[Lldb-commits] [PATCH] D78978: [LLDB] Add support for WebAssembly debugging

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 8 16:00:47 PST 2021


aprantl added a comment.

What's the testing story for WASM going to be?



================
Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h:300
 
+  // WebAssembly-specific commands
+  bool GetWasmGlobal(int frame_index, int index, void *buf, size_t buffer_size,
----------------
Nit:

/// WebAssembly-specific commands
/// \{
...
/// \}

Even better would be doxygen comments for all functions.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78978/new/

https://reviews.llvm.org/D78978



More information about the lldb-commits mailing list