[Lldb-commits] [PATCH] D94008: [LLDB] DynamicRegisterInfo calculate offsets in separate function

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jan 6 05:50:08 PST 2021


labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

LG, modulo inline comment.



================
Comment at: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.h:45-46
 
+  void ConfigureOffsets();
+
   size_t GetNumRegisters() const;
----------------
Users should not be calling this, right? Could we make this protected?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94008/new/

https://reviews.llvm.org/D94008



More information about the lldb-commits mailing list