[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

Tue Jan 5 12:05:55 PST 2021

clayborg added a comment.

In D93895#2479845 <https://reviews.llvm.org/D93895#2479845>, @augusto2112 wrote:

> Question: why does lldb queries if vAttachOrWait is supported, but not vAttachWait? Does it make sense to keep this query? Or should I remove it?

"vAttachOrWait" allows you to attach to a process by name even if it already exists, where "vAttachWait" will ignore any current existing processes with a matching name. LLDB will fall back to using vAttachWait if the users requested to NOT ignore existing processes since some support for waiting for a process by  name is better than nothing. So we need to check for vAttachOrWait so we can use it if needed to allow attaching to an existing process if the user requested it. So since this is very similar code to what you have it just doesn't make an ignore list like you did in this patch. So it might be nice to add support for vAttachOrWait, along with the query packet, in this patch if you have the time? Let me know if you have any questions.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93895/new/

https://reviews.llvm.org/D93895