[Lldb-commits] [PATCH] D93895: Implement vAttachWait in lldb-server

Augusto Noronha via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jan 1 13:33:24 PST 2021


augusto2112 added a comment.

Hi @labath. Ok, I believe the test is passing now. Thank you for all the help today!

Question: the original author left a TODO:

  // TODO: Make the polling interval configurable
  std::chrono::milliseconds waitfor_interval = std::chrono::seconds(1);

Is this  a lot of work? Is it worth it to do this together in this patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93895/new/

https://reviews.llvm.org/D93895



More information about the lldb-commits mailing list