[Lldb-commits] [PATCH] D93874: [process] fix exec support on Linux

Fri Jan 1 12:19:48 PST 2021

labath added a comment.

The new version seems ok-ish to me, but I'm leaving it open as I'd like Jim to weigh in here. The immediate cause of the crash is related to the (dangling?) m_thread pointer inside the completed "step instruction" plan. Normally, this pointer clears itself when the thread disappears but I guess this does not happen in the exec case. Jim should know what's the expected behavior here.

================
Comment at: lldb/test/API/functionalities/exec/TestExec.py:91-93
+        # Single step to create a thread plan. We have to make sure that after exec
+        # we clear all existing thread plans.
+        thread.StepInstruction(False)
----------------
A separate test case would be better, as (even with the comment) a random future modification of the test could negate this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93874/new/

https://reviews.llvm.org/D93874