[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.
Ed Maste via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Thu Dec 31 12:01:55 PST 2020
emaste added inline comments.
Comment at: lldb/source/Plugins/Process/POSIX/CrashReason.cpp:62
+#define SEGV_MTEAERR 8
> emaste wrote:
> > emaste wrote:
> > > This should perhaps include an `#ifdef LINUX`(sp?) somehow, since 8 and 9 are not necessarily MTEAERR / MTESERR on all POSIXy systems (although that said I'm planning to reserve 8 and 9 on FreeBSD to match).
> > (https://reviews.freebsd.org/D27785)
> Makes sense, done.
> For now I left SEGV_BNDERR as is, although it doesn't appear that any of FreeBSD, OpenBSD, NetBSD, illumos or XNU have defined anything besides SEGV_MAPERR and SEGV_ACCERR so it might be good to put SEGV_BNDERR under the #ifdef as well.
What do you think about
#define SEGV_MTEAERR 8
We're likely to have `SEGV_MTEAERR` in FreeBSD soon
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits