[Lldb-commits] [lldb] 37974b4 - [lldb/test] Enable reverse-connect on windows too

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Sun Dec 20 01:38:06 PST 2020


Author: Pavel Labath
Date: 2020-12-20T10:37:48+01:00
New Revision: 37974b493a48cf97ac3d486512d6cd70c176924a

URL: https://github.com/llvm/llvm-project/commit/37974b493a48cf97ac3d486512d6cd70c176924a
DIFF: https://github.com/llvm/llvm-project/commit/37974b493a48cf97ac3d486512d6cd70c176924a.diff

LOG: [lldb/test] Enable reverse-connect on windows too

It works, and it should be more stable than forward connections.

Added: 
    

Modified: 
    lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

Removed: 
    


################################################################################
diff  --git a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
index 03cf2d4ab981..0e3cde01520a 100644
--- a/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
+++ b/lldb/packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py
@@ -195,10 +195,6 @@ def _init_llgs_test(self):
             # Remove if it's there.
             self.debug_monitor_exe = re.sub(r' \(deleted\)$', '', exe)
         else:
-            # TODO: enable this
-            if platform.system() == 'Windows':
-                reverse_connect = False
-
             self.debug_monitor_exe = get_lldb_server_exe()
             if not self.debug_monitor_exe:
                 self.skipTest("lldb-server exe not found")


        


More information about the lldb-commits mailing list