[Lldb-commits] [PATCH] D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes

Thu Dec 17 02:04:13 PST 2020

labath accepted this revision.
labath added inline comments.

================
Comment at: lldb/unittests/Process/Utility/CMakeLists.txt:4-5
   RegisterContextFreeBSDTest.cpp
+  RegisterContextNetBSDTest_i386.cpp
+  RegisterContextNetBSDTest_x86_64.cpp
   LinuxProcMapsTest.cpp
----------------
mgorny wrote:
> labath wrote:
> > What's reason for having these as separate files (vs. the all-in-one freebsd approach)?
> `struct reg` collision. NetBSD doesn't have unique names like FreeBSD does.
I see. Somewhat unfortunate, but such is life... I'd consider splitting the FreeBSD version too, for consistency, but I don't feel very strongly about that..

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93299/new/

https://reviews.llvm.org/D93299