[Lldb-commits] [PATCH] D93299: [lldb] [unittests] Add tests for NetBSD register offsets/sizes

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: lldb/unittests/Process/Utility/CMakeLists.txt:4-5
   RegisterContextFreeBSDTest.cpp
+  RegisterContextNetBSDTest_i386.cpp
+  RegisterContextNetBSDTest_x86_64.cpp
   LinuxProcMapsTest.cpp
----------------
What's reason for having these as separate files (vs. the all-in-one freebsd approach)?


================
Comment at: lldb/unittests/Process/Utility/RegisterContextNetBSDTest_i386.cpp:9
+
+#if defined(__NetBSD__)
+
----------------
I guess we could now (that we have other, unconditionally compiled files), upgrade this to `if(CMAKE_SYSTEM_NAME == NetBSD`)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93299/new/

https://reviews.llvm.org/D93299