[Lldb-commits] [PATCH] D93225: [lldb] Add helper class for dealing with key:value; GDB responses
David Spickett via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Dec 14 08:36:06 PST 2020
DavidSpickett added reviewers: labath, jasonmolenda.
DavidSpickett added a comment.
I realise it's a lot to review but if you have any initial comments on the usability that'd be great. My main point here was to make the if-else chain a bit "safer" and more easily extended. The parsing logic itself I did not change, to keep things clear (though I would like to improve it later).
I've also put up https://reviews.llvm.org/D93226 where you can see how it changes qProcessInfo parsing.
There are a few more packets that could benefit to varying degrees. (some are just 1/2 keys)
- qProcessInfo again (in GetCurrentProcessInfo)
A quick look over them doesn't show anything that would prevent KeyValueExtractorGDBRemote from applying there too if it proves useful here.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the lldb-commits