[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

[Jim Ingham via Phabricator via lldb-commits]

jingham added a comment.

It's a little awkward that you have the "do_select" parameter with a default argument of "true" but then you explicitly pass "true" every time you use it...

It seems reasonable that the Debugger might want to create targets w/o selecting them.  For instance, suppose we had some mechanism to say "attach to everything that the currently being debugged process launches", and you were stepping over the routine in the main target that creates a new process, we will make a new target for the child process, but you really wouldn't want to make the new process' target the default target, it hasn't done anything interesting yet...  So having the parameter there seems right.  But either use the default value or don't have it.  I'm in favor of the latter, it's good for people to see that the selected target is going to get switched by this call.

Other than that, this seems fine to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93052/new/

https://reviews.llvm.org/D93052